Summary: | Update the design of the WebKit Feature Status page | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Davis <jond> | ||||||
Component: | WebKit Website | Assignee: | Jon Davis <jond> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jond, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jon Davis
2017-06-06 14:48:06 PDT
Created attachment 312126 [details]
Patch
Comment on attachment 312126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312126&action=review > Websites/webkit.org/wp-content/themes/webkit/status.php:573 > + console.log(specification); Probably don't want this log here. > Websites/webkit.org/wp-content/themes/webkit/status.php:629 > + link.href = "#feature-" + feature.name.toLowerCase().replace(/ /g, '-'); How does navigating to this link interact with search? > Websites/webkit.org/wp-content/themes/webkit/status.php:641 > + moreInfoList.className = 'moreinfo' semicolon at the end > Websites/webkit.org/wp-content/themes/webkit/status.php:654 > + li.className = "contact" semicolon > Websites/webkit.org/wp-content/themes/webkit/status.php:739 > + label.className = "filter-status " + statusId semicolon > Websites/webkit.org/wp-content/themes/webkit/status.php:802 > + //updateSpecsState(); Remove commented code. > Websites/webkit.org/wp-content/themes/webkit/status.php:857 > + > + Blank lines. Created attachment 312153 [details]
Patch
Comment on attachment 312153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312153&action=review > Websites/webkit.org/wp-content/themes/webkit/status.php:108 > + color: #ffffff; This can be #fff or 'white'. > Websites/webkit.org/wp-content/themes/webkit/status.php:123 > + border-color: #999999; #999 > Websites/webkit.org/wp-content/themes/webkit/status.php:266 > + color: #999999; #999 > Websites/webkit.org/wp-content/themes/webkit/status.php:287 > + background: #ffffff; #fff or white > Websites/webkit.org/wp-content/themes/webkit/status.php:322 > + color: #666666; #666 Comment on attachment 312153 [details] Patch Clearing flags on attachment: 312153 Committed r217885: <http://trac.webkit.org/changeset/217885> All reviewed patches have been landed. Closing bug. |