Bug 173036

Summary:

Update the design of the WebKit Feature Status page

Product:

WebKit

Reporter:

Jon Davis <jond>

Component:

WebKit Website

Assignee:

Jon Davis <jond>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jond, simon.fraser

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Jon Davis

Reported 2017-06-06 14:48:06 PDT

Update the design of the feature status page to better handle different screen sizes and improve the color scheme of status labels.

Attachments
Patch (37.70 KB, patch) 2017-06-06 14:57 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Patch (37.72 KB, patch) 2017-06-06 18:56 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jon Davis

Comment 1 2017-06-06 14:57:20 PDT

Created attachment 312126 [details] Patch

Simon Fraser (smfr)

Comment 2 2017-06-06 15:12:59 PDT

Comment on attachment 312126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312126&action=review > Websites/webkit.org/wp-content/themes/webkit/status.php:573 > + console.log(specification); Probably don't want this log here. > Websites/webkit.org/wp-content/themes/webkit/status.php:629 > + link.href = "#feature-" + feature.name.toLowerCase().replace(/ /g, '-'); How does navigating to this link interact with search? > Websites/webkit.org/wp-content/themes/webkit/status.php:641 > + moreInfoList.className = 'moreinfo' semicolon at the end > Websites/webkit.org/wp-content/themes/webkit/status.php:654 > + li.className = "contact" semicolon > Websites/webkit.org/wp-content/themes/webkit/status.php:739 > + label.className = "filter-status " + statusId semicolon > Websites/webkit.org/wp-content/themes/webkit/status.php:802 > + //updateSpecsState(); Remove commented code. > Websites/webkit.org/wp-content/themes/webkit/status.php:857 > + > + Blank lines.

Jon Davis

Comment 3 2017-06-06 18:56:33 PDT

Created attachment 312153 [details] Patch

Simon Fraser (smfr)

Comment 4 2017-06-06 19:08:55 PDT

Comment on attachment 312153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312153&action=review > Websites/webkit.org/wp-content/themes/webkit/status.php:108 > + color: #ffffff; This can be #fff or 'white'. > Websites/webkit.org/wp-content/themes/webkit/status.php:123 > + border-color: #999999; #999 > Websites/webkit.org/wp-content/themes/webkit/status.php:266 > + color: #999999; #999 > Websites/webkit.org/wp-content/themes/webkit/status.php:287 > + background: #ffffff; #fff or white > Websites/webkit.org/wp-content/themes/webkit/status.php:322 > + color: #666666; #666

WebKit Commit Bot

Comment 5 2017-06-07 09:04:40 PDT

Comment on attachment 312153 [details] Patch Clearing flags on attachment: 312153 Committed r217885: <http://trac.webkit.org/changeset/217885>

WebKit Commit Bot

Comment 6 2017-06-07 09:04:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.