Bug 17300

Summary:

WebKit should support Cairo and CoreGraphics on Windows

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, richbail

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Visual Studio Project File	none
Cairo version of WebKit project	none
Cairo version of WebCore project	none
Cairo version of WebKit project	none
Cairo version of WebCore.vcproj	none
Cairo version of WebKit.vcproj	none
Cairo version of WebCore.vcproj	none
Merged to single Project File	none
No longer use vsprops file	aroben: review+

Brent Fulgham

Reported 2008-02-10 15:43:17 PST

Currently, the WebKit build on Windows only supports the CoreGraphics target. Users wishing to use WebKit as part of a redistributable product cannot ship these proprietary Apple libraries, and so must build a Cairo-based variant. Unfortunately, the existing Visual Studio projects and solution files do not support the Cairo build. At the moment, I have to swap out a set of custom project files, remembering to change back to the 'stock' versions before performing a 'svn update'. I propose devising a means to support either type of build, preferably from a single set of project files to help keep the two versions in sync.

Attachments
Visual Studio Project File (245.00 KB, application/xml) 2008-02-10 15:45 PST, Brent Fulgham	no flags	Details
Cairo version of WebKit project (51.85 KB, application/xml) 2008-02-10 15:47 PST, Brent Fulgham	no flags	Details
Cairo version of WebCore project (245.02 KB, application/xml) 2008-02-12 16:25 PST, Brent Fulgham	no flags	Details
Cairo version of WebKit project (51.91 KB, application/xml) 2008-02-12 16:26 PST, Brent Fulgham	no flags	Details
Cairo version of WebCore.vcproj (245.12 KB, application/xml) 2008-02-18 17:50 PST, Brent Fulgham	no flags	Details
Cairo version of WebKit.vcproj (52.90 KB, application/xml) 2008-02-18 17:51 PST, Brent Fulgham	no flags	Details
Cairo version of WebCore.vcproj (245.57 KB, application/xml) 2008-02-28 12:00 PST, Brent Fulgham	no flags	Details
Merged to single Project File (105.50 KB, patch) 2008-03-06 12:21 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
No longer use vsprops file (108.03 KB, patch) 2008-03-07 11:12 PST, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2008-02-10 15:45:48 PST

Created attachment 19053 [details] Visual Studio Project File This file is the WebCore.vcproj required to build a Cairo-based WebCore library. It repeats large portions of the original WebCore.vcproj; it would be nice if the two could somehow be merged.

Brent Fulgham

Comment 2 2008-02-10 15:47:45 PST

Created attachment 19054 [details] Cairo version of WebKit project This is the Cairo-based WebKit project file. It duplicates large portions of the main WebKit.vcproj file; it would be nice if the two could somehow be combined.

Brent Fulgham

Comment 3 2008-02-12 16:25:29 PST

Created attachment 19096 [details] Cairo version of WebCore project

Brent Fulgham

Comment 4 2008-02-12 16:26:08 PST

Created attachment 19097 [details] Cairo version of WebKit project

Brent Fulgham

Comment 5 2008-02-12 16:26:32 PST

Updated for Cairo version with working font/browsing.

Brent Fulgham

Comment 6 2008-02-18 17:50:42 PST

Created attachment 19200 [details] Cairo version of WebCore.vcproj

Brent Fulgham

Comment 7 2008-02-18 17:51:22 PST

Created attachment 19201 [details] Cairo version of WebKit.vcproj

Brent Fulgham

Comment 8 2008-02-28 12:00:06 PST

Created attachment 19439 [details] Cairo version of WebCore.vcproj

Brent Fulgham

Comment 9 2008-03-06 12:21:44 PST

Created attachment 19574 [details] Merged to single Project File * Cairo and CG sources part of same project file. * Added new webcore.vsprops file to store common defines between project targets. * New "Debug_Cairo" and "Release_Cairo" targets that exclude CG sources. * "Debug" and "Release" targets exclude Cairo sources. * WebKit.sln updated to recognize "Debug_Cairo" and "Release_Cairo" targets. * WebKit.vcproj updated to links the *_Cairo builds against Cario, libjpeg, etc.

Brent Fulgham

Comment 10 2008-03-07 11:12:52 PST

Created attachment 19591 [details] No longer use vsprops file Revised per sfalken comments: * No longer use vsprops file.

Adam Roben (:aroben)

Comment 11 2008-03-07 11:46:02 PST

Comment on attachment 19591 [details] No longer use vsprops file r=sfalken

Mark Rowe (bdash)

Comment 12 2008-03-07 13:14:51 PST

Landed in r30876.

Note You need to log in before you can comment on or make changes to this bug.