Summary: | Patch providing fully-buildable Cairo-backed Win32 WebCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, webkit | ||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Brent Fulgham
2008-02-10 15:36:04 PST
Created attachment 19051 [details]
Patch for Cairo support in WebCore.
Note that this bug is related to Bug #17300 (though it does not depend on its soution). Comment on attachment 19051 [details] Patch for Cairo support in WebCore. Patch looks good. Some small issues: #include "config.h" +#include "PlatformString.h" +#include "CSSValueKeywords.h" #include "RenderThemeWin.h" New includes should go in a separate group. See the <http://webkit.org/coding/coding-style.html> section called "#include statements". + cachedDesc->firstFamily().setFamily("Lucida Grande"); Are you sure that's the right choice? I don't think that font is included by default on Windows. (In reply to comment #3) > + cachedDesc->firstFamily().setFamily("Lucida Grande"); > > Are you sure that's the right choice? I don't think that font is included by > default on Windows. > On Windows there is a similar font called Lucida Sans Unicode -> http://en.wikipedia.org/wiki/Lucida_Sans_Unicode Comment on attachment 19051 [details]
Patch for Cairo support in WebCore.
I'll just take this and tweak it and land it.
(In reply to comment #5) > (From update of attachment 19051 [details] [edit]) > I'll just take this and tweak it and land it. > Oh, thanks! I was going to research the proper font to use; currently it doesn't really matter because the font rendering is getting hung up somewhere else. I'm trying to debug it today as time allows. Comment on attachment 19051 [details]
Patch for Cairo support in WebCore.
Committed revision 30143.
|