| Summary: | fast/frames/sandboxed-iframe-navigation-top-denied.html is crashing in Inspector::createScriptCallStackForConsole::Exec for GTK | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Web Inspector | Assignee: | Fujii Hironori <Hironori.Fujii> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, ews-watchlist, Hironori.Fujii, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, rniwa, saam, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: | |||
|
Description
Michael Catanzaro
2017-06-05 20:29:17 PDT
Created attachment 332948 [details] debug patch This crash can't be reproduced with Debug build. But, if I apply this debug patch, I can reproduce the crash with Debug build. GTK port, Debug build, trunk@227995 Crash log: https://gist.github.com/fujii/880103ac36491f17b0affa429870a78c Comment on attachment 332948 [details] debug patch Attachment 332948 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6329325 New failing tests: fast/frames/sandboxed-iframe-navigation-top-denied.html Created attachment 332952 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 332948 [details] debug patch Attachment 332948 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6329338 New failing tests: fast/frames/sandboxed-iframe-navigation-top-denied.html Created attachment 332953 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 332948 [details] debug patch Attachment 332948 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6329365 New failing tests: fast/frames/sandboxed-iframe-navigation-top-denied.html Created attachment 332954 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 332948 [details] debug patch Attachment 332948 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6330425 New failing tests: fast/frames/sandboxed-iframe-navigation-top-denied.html Created attachment 332964 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
These EWS test failures means mac port also have this null dereference issue. What does it mean if topCallFrame is null? Should I do null-check? (In reply to Fujii Hironori from comment #10) > These EWS test failures means mac port also have this null dereference issue. > What does it mean if topCallFrame is null? > Should I do null-check? I guess that's because scripts are not executed at all in this case. I need to do null-check there. Created attachment 333058 [details]
Patch
Comment on attachment 333058 [details] Patch Clearing flags on attachment: 333058 Committed r228561: <https://trac.webkit.org/changeset/228561> All reviewed patches have been landed. Closing bug. |