Bug 172944

Summary: OMG tier up checks should be a patchpoint
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mark.lam, msaboff, ryanhaddad, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Keith Miller
Reported 2017-06-05 17:21:39 PDT
OMG tier up checks should be a patchpoint
Attachments
Patch (9.49 KB, patch)
2017-06-05 17:23 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.60 KB, patch)
2017-06-06 14:41 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-06-05 17:23:33 PDT
Created attachment 312039 [details] Patch
Saam Barati
Comment 2 2017-06-05 18:40:18 PDT
Comment on attachment 312039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312039&action=review > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:913 > + MacroAssembler::Call call = jit.nearCall(); > + > + ScratchRegisterAllocator::restoreRegistersFromStackForCall(jit, registersToSpill, RegisterSet(), numberOfStackBytesUsedForRegisterPreservation, extraPaddingBytes); This code looks wrong. You're not restoring SP after the call. Are tests passing? I'm also looking at our other wasm call code, and wondering how any of it works since none of it restores SP. > Source/JavaScriptCore/wasm/WasmThunks.cpp:120 > + jit.call(GPRInfo::argumentGPR2); ditto
Saam Barati
Comment 3 2017-06-05 19:04:39 PDT
Comment on attachment 312039 [details] Patch Ignore me, C CC says SP is callee save.
WebKit Commit Bot
Comment 4 2017-06-05 19:34:55 PDT
Comment on attachment 312039 [details] Patch Clearing flags on attachment: 312039 Committed r217812: <http://trac.webkit.org/changeset/217812>
WebKit Commit Bot
Comment 5 2017-06-05 19:34:57 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 6 2017-06-06 09:16:18 PDT
Reverted r217812 for reason: This change caused test failures on arm64. Committed r217833: <http://trac.webkit.org/changeset/217833>
Ryan Haddad
Comment 7 2017-06-06 09:16:47 PDT
(In reply to Ryan Haddad from comment #6) > Reverted r217812 for reason: > > This change caused test failures on arm64. > > Committed r217833: <http://trac.webkit.org/changeset/217833> <rdar://problem/32590017>
Keith Miller
Comment 8 2017-06-06 14:41:49 PDT
Created attachment 312121 [details] Patch for landing
WebKit Commit Bot
Comment 9 2017-06-06 15:20:19 PDT
Comment on attachment 312121 [details] Patch for landing Clearing flags on attachment: 312121 Committed r217861: <http://trac.webkit.org/changeset/217861>
WebKit Commit Bot
Comment 10 2017-06-06 15:20:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.