Bug 172928

Summary: webkitpy: Abstract Executive class
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, glenn, jbedard, lforschler, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch rniwa: review+

Daniel Bates
Reported 2017-06-05 11:29:48 PDT
We should abstract the Executive class so to make it straightforward to define derived classes. This will be useful to support iOS on-device testing.
Attachments
Patch (12.21 KB, patch)
2017-06-05 11:35 PDT, Daniel Bates 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-05 11:30:24 PDT
<rdar://problem/32569531>
Daniel Bates
Comment 2 2017-06-05 11:35:53 PDT
Created attachment 312019 [details] Patch
Ryosuke Niwa
Comment 3 2017-06-05 12:30:11 PDT
Comment on attachment 312019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312019&action=review > Tools/Scripts/webkitpy/common/system/abstractexecutive.py:120 > + def run_command(self, > + args, Nit: Wrong indentation. Arguments should be indented by exactly 4 spaces. But I don't think we need to wrap for each argument like this.
Daniel Bates
Comment 4 2017-06-05 16:01:32 PDT
Committed r217801: <http://trac.webkit.org/changeset/217801>
Note You need to log in before you can comment on or make changes to this bug.