Bug 172916

Summary: [GTK][WPE] Do not force video sample's buffer release when the platformLayerProxy is inactive
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Miguel Gomez
Reported 2017-06-05 03:39:29 PDT
In bug https://bugs.webkit.org/show_bug.cgi?id=168505 a workaround was added to avoid locking all the available gstreamer buffers inside the plarformLayerProxy in case it was set to display:none. This is not needed anymore since setting the video element to display:none will invalidate the platformLayerProxy, freeing all the buffers. Also, this change is causing problems when using gstreamer-gl and trying to paint video frames through webgl or an accelerated canvas, as the video sample's buffers will be empty and a crash will happen.
Attachments
Patch (2.99 KB, patch)
2017-06-05 03:48 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2017-06-05 03:48:39 PDT
Created attachment 312003 [details] Patch
WebKit Commit Bot
Comment 2 2017-06-05 05:33:35 PDT
Comment on attachment 312003 [details] Patch Clearing flags on attachment: 312003 Committed r217780: <http://trac.webkit.org/changeset/217780>
WebKit Commit Bot
Comment 3 2017-06-05 05:33:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.