Bug 172910

Summary: Start using NO_IMPLICIT_ATOMICSTRING
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, sam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2017-06-04 19:09:49 PDT
Start using NO_IMPLICIT_ATOMICSTRING
Attachments
Patch (89.10 KB, patch)
2017-06-04 19:28 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (66.98 KB, patch)
2017-06-06 15:07 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-06-04 19:28:50 PDT
Created attachment 311977 [details] Patch
Chris Dumez
Comment 2 2017-06-04 19:42:55 PDT
Comment on attachment 311977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311977&action=review > Source/WebCore/dom/PopStateEvent.idl:28 > + Constructor([AtomicString] DOMString type, optional PopStateEventInit eventInitDict), As commented via mail, I don't really like that we are sprinkling [AtomicString] everywhere in the IDL. I wish our generated bindings code would use a type that could be implicitly converted to a String or an AtomicString. Then, the implementation would have control over what is used (without any need for an IDL extended attribute).
Darin Adler
Comment 3 2017-06-06 15:07:22 PDT
Created attachment 312127 [details] Patch
Darin Adler
Comment 4 2017-06-06 15:07:52 PDT
(In reply to Chris Dumez from comment #2) > As commented via mail, I don't really like that we are sprinkling > [AtomicString] everywhere in the IDL. I will save that change for a separate patch.
Darin Adler
Comment 5 2017-07-23 15:12:31 PDT
We decided not to do this; not now, and likely never. Chris said that he did this in Chromium and we never measured any benefit.
Note You need to log in before you can comment on or make changes to this bug.