Bug 172858

Summary: [MediaStream iOS] Cleanup video muting/unmuting when tab visibility changes
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
eric.carlson: review+
Patch for landing.
none
Patch for landing. none

Eric Carlson
Reported 2017-06-02 08:09:47 PDT
Don't unmute a video when a tab becomes visible unless it was muted when the tab was hidden.
Attachments
Proposed patch. (12.03 KB, patch)
2017-06-02 08:22 PDT, Eric Carlson 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing. (4.86 KB, patch)
2017-06-02 10:50 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (12.05 KB, patch)
2017-06-02 13:38 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-06-02 08:22:02 PDT
Created attachment 311827 [details] Proposed patch.
Eric Carlson
Comment 2 2017-06-02 10:20:13 PDT
Comment on attachment 311827 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=311827&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:337 > +void RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility(bool muted) shouldMute instead of muted? > LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html:67 > + Double space line
Eric Carlson
Comment 3 2017-06-02 10:44:59 PDT
(In reply to Eric Carlson from comment #2) > Comment on attachment 311827 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311827&action=review > > > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:337 > > +void RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility(bool muted) > > shouldMute instead of muted? > > > LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html:67 > > + > > Double space line (Comments by Youenn on my machine)
Eric Carlson
Comment 4 2017-06-02 10:50:44 PDT
Created attachment 311839 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2017-06-02 11:21:06 PDT
Comment on attachment 311839 [details] Patch for landing. Rejecting attachment 311839 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: bjects-normal/x86_64/FEComposite.dia -c /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/filters/FEComposite.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/FEComposite.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/Document.o dom/Document.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/3860671
Eric Carlson
Comment 6 2017-06-02 13:38:51 PDT
Created attachment 311855 [details] Patch for landing.
WebKit Commit Bot
Comment 7 2017-06-02 14:16:57 PDT
Comment on attachment 311855 [details] Patch for landing. Clearing flags on attachment: 311855 Committed r217734: <http://trac.webkit.org/changeset/217734>
Ahmad Saleem
Comment 8 2022-10-05 16:23:32 PDT
Seems landed and didn't back out. https://github.com/WebKit/WebKit/commit/b47636fb155e81e898fc91fb11959757194bf78d Marking this as "RESOLVED FIXED". Thanks!
Radar WebKit Bug Importer
Comment 9 2022-10-05 16:24:18 PDT
<rdar://problem/100828817>
Note You need to log in before you can comment on or make changes to this bug.