Bug 172840

Summary: Resource Load Statistics: Skip plugin data in grandfathering to avoid text diff test failures
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit2Assignee: John Wilander <wilander>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dbates, jbedard, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174652
https://bugs.webkit.org/show_bug.cgi?id=174720
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

John Wilander
Reported 2017-06-01 16:41:22 PDT
Plugins occasionally cause text diff layout test failures (<rdar://problem/30493994>). Grandfathering on fresh starts makes that happen a lot more often which is hurting developers who don't want to uninstall their plugins. Therefore we should skip plugin data in grandfathering for the time being.
Attachments
Patch (2.46 KB, patch)
2017-06-01 16:44 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2017-06-01 16:51 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (2.56 KB, patch)
2017-06-01 16:54 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (2.58 KB, patch)
2017-07-19 10:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-01 16:41:57 PDT
<rdar://problem/32524816>
John Wilander
Comment 2 2017-06-01 16:44:28 PDT
Created attachment 311778 [details] Patch
John Wilander
Comment 3 2017-06-01 16:51:08 PDT
Created attachment 311779 [details] Patch
John Wilander
Comment 4 2017-06-01 16:54:58 PDT
Created attachment 311781 [details] Patch
John Wilander
Comment 5 2017-06-02 12:12:30 PDT
Turns out this change doesn’t seem to fix the issue. It may be we have to turn off grandfathering by default in tests instead.
Jonathan Bedard
Comment 6 2017-07-19 10:03:35 PDT
Created attachment 315928 [details] Patch
Jonathan Bedard
Comment 7 2017-07-19 10:05:56 PDT
(In reply to Jonathan Bedard from comment #6) > Created attachment 315928 [details] > Patch This patch will 'fix' the issue, but I don't think this is addressing the root cause. I think https://bugs.webkit.org/show_bug.cgi?id=174652 is the root cause.
Jonathan Bedard
Comment 8 2017-07-21 11:07:25 PDT
This just looks to be a testing harness issue. I've filed https://bugs.webkit.org/show_bug.cgi?id=174720 with the fix in the WebKitTestRunner.
Note You need to log in before you can comment on or make changes to this bug.