Bug 172832

Summary: [Cocoa] Add a "supportedCountries" property to ApplePayPaymentRequest
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, ap, bdakin, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, ggaren, kondapallykalyan, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2017-06-01 13:22:10 PDT
[Cocoa] Add a "supportedCountries" property to ApplePayPaymentRequest
Attachments
Patch (16.30 KB, patch)
2017-06-01 13:25 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (16.37 KB, patch)
2017-06-01 13:53 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (16.47 KB, patch)
2017-06-01 13:55 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (16.47 KB, patch)
2017-06-02 10:30 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (16.97 KB, patch)
2017-06-02 10:34 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-06-01 13:22:51 PDT
rdar://problem/30735544
Andy Estes
Comment 2 2017-06-01 13:25:59 PDT
Created attachment 311750 [details] Patch
Andy Estes
Comment 3 2017-06-01 13:53:27 PDT
Created attachment 311754 [details] Patch
Andy Estes
Comment 4 2017-06-01 13:55:36 PDT
Created attachment 311756 [details] Patch
Alex Christensen
Comment 5 2017-06-01 14:44:08 PDT
Comment on attachment 311756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311756&action=review > Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h:61 > + std::optional<Vector<String>> supportedCountries; I'm not sure the difference between nullopt and an empty vector is important enough to make this an optional vector. > LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:23 > +SETUP: request = validRequest(); request.supportedCountries = 7; > +PASS new ApplePaySession(3, request) threw exception TypeError: Value is not a sequence. Let's add a test that contains a valid sequence that contains things that are not strings. Also an empty sequence.
Andy Estes
Comment 6 2017-06-02 10:30:41 PDT
Created attachment 311837 [details] Patch
Andy Estes
Comment 7 2017-06-02 10:34:58 PDT
Created attachment 311838 [details] Patch
WebKit Commit Bot
Comment 8 2017-06-02 11:14:50 PDT
Comment on attachment 311838 [details] Patch Clearing flags on attachment: 311838 Committed r217723: <http://trac.webkit.org/changeset/217723>
WebKit Commit Bot
Comment 9 2017-06-02 11:14:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.