| Summary: | [Cocoa] Add a "supportedCountries" property to ApplePayPaymentRequest | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, andersca, ap, bdakin, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, ggaren, kondapallykalyan, sam, thorton, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Andy Estes
2017-06-01 13:22:10 PDT
Created attachment 311750 [details]
Patch
Created attachment 311754 [details]
Patch
Created attachment 311756 [details]
Patch
Comment on attachment 311756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311756&action=review > Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h:61 > + std::optional<Vector<String>> supportedCountries; I'm not sure the difference between nullopt and an empty vector is important enough to make this an optional vector. > LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:23 > +SETUP: request = validRequest(); request.supportedCountries = 7; > +PASS new ApplePaySession(3, request) threw exception TypeError: Value is not a sequence. Let's add a test that contains a valid sequence that contains things that are not strings. Also an empty sequence. Created attachment 311837 [details]
Patch
Created attachment 311838 [details]
Patch
Comment on attachment 311838 [details] Patch Clearing flags on attachment: 311838 Committed r217723: <http://trac.webkit.org/changeset/217723> All reviewed patches have been landed. Closing bug. |