Summary: | webarchive/loading/mainresource-null-mimetype-crash.html / webarchive/loading/missing-data.html are flaky | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, buildbot, commit-queue, ggaren, lforschler, rniwa | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2017-06-01 10:12:40 PDT
Created attachment 311719 [details]
Patch
Comment on attachment 311719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311719&action=review > Source/WebCore/ChangeLog:8 > + Do not assume the document's frame and page pointers are non null in WebCoreTestSupport::resetInternalsObject(). Is that actually an expected situation, or is the root cause elsewhere? I thought that we always needed to reset the state, so returning early would result in misconfigured tetsing down the line. Note that there are other crashes happening on this test, so I assumed it was a WebCore issue. Comment on attachment 311719 [details] Patch Attachment 311719 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3854789 New failing tests: webrtc/peer-connection-audio-mute.html Created attachment 311738 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
(In reply to Alexey Proskuryakov from comment #4) > Note that there are other crashes happening on this test, so I assumed it > was a WebCore issue. The issue is that this test navigates the main frame. When that happens, a new document is created and associated to the main frame. The old document is then frameless. My bet , since it is flaky, is that we sometimes call resetInternalsObject() on the old document (pre-navigation) and sometimes on the new document (post-navigation). One thing I think we should do is update the test to na Created attachment 311740 [details]
Patch
Comment on attachment 311740 [details]
Patch
rs=me. Seems reasonable to work around this in tests for now.
Comment on attachment 311740 [details] Patch Clearing flags on attachment: 311740 Committed r217680: <http://trac.webkit.org/changeset/217680> All reviewed patches have been landed. Closing bug. |