Bug 172818

Summary: webkitpy: Do not send 0 or -1 as a pid to kill_process
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, darin, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2017-06-01 09:06:54 PDT
0 and -1 do have meaning when killing a process, but if they are sent to executive.kill_process(...), this indicates a bug. executive.kill_process(...) is intended to be used to kill a single process. Throw an exception when a pid which is undefined, 0 or negative is passed into executive.kill_process(...). We should also fix the existing case where we know kill_process(...) could receive an illegal pid.
Attachments
Patch (3.25 KB, patch)
2017-06-01 09:17 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-01 09:08:25 PDT
<rdar://problem/32512215>
Jonathan Bedard
Comment 2 2017-06-01 09:17:13 PDT
Created attachment 311710 [details] Patch
WebKit Commit Bot
Comment 3 2017-06-01 09:36:02 PDT
Comment on attachment 311710 [details] Patch Clearing flags on attachment: 311710 Committed r217658: <http://trac.webkit.org/changeset/217658>
WebKit Commit Bot
Comment 4 2017-06-01 09:36:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.