Bug 172813

Summary: fast/events/touch/document-create-touch.html is failing since r217390
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bugs-noreply, commit-queue, mcatanzaro, Ms2ger
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Miguel Gomez
Reported 2017-06-01 08:40:46 PDT
There were some updates in the tests in r217390 and this started to fail there. fast/events/touch/document-create-touch.html [ Failure ]
Attachments
Patch (6.78 KB, patch)
2017-08-28 07:21 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Alexey Proskuryakov
Comment 1 2017-06-01 09:15:11 PDT
What does the failure look like?
Michael Catanzaro
Comment 2 2017-06-01 09:30:52 PDT
Thanks Miguel! Let's try to post text diffs, or links to image diffs, when convenient: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/touch/document-create-touch-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/touch/document-create-touch-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 39: TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow +CONSOLE MESSAGE: line 53: TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow This tests support for the document.createTouch API. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Michael Catanzaro
Comment 3 2017-06-01 09:32:43 PDT
I think we should just update the expectation as it's expected that line numbers will change after that revision.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2017-08-28 07:21:22 PDT
WebKit Commit Bot
Comment 5 2017-08-28 09:52:51 PDT
Comment on attachment 319178 [details] Patch Clearing flags on attachment: 319178 Committed r221261: <http://trac.webkit.org/changeset/221261>
WebKit Commit Bot
Comment 6 2017-08-28 09:52:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.