Bug 172778

Summary: Make QualifiedName cache per thread
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, buildbot, bweinstein, commit-queue, dbates, esprehn+autocc, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-05-31 14:41:13 PDT
Make QualifiedName cache per thread since it is currently used from multiple thread in an unsafe fashion. We started using QualifiedName objects in background threads after r190602 which started using a CSSSelectorParser in the ContentExtensionParser.
Attachments
Patch (17.17 KB, patch)
2017-05-31 14:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.66 KB, patch)
2017-05-31 14:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-31 14:41:26 PDT
<rdar://problem/32490942>
Chris Dumez
Comment 2 2017-05-31 14:43:28 PDT
Created attachment 311636 [details] Patch
Build Bot
Comment 3 2017-05-31 14:44:39 PDT
Attachment 311636 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ThreadGlobalData.h:39: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2017-05-31 14:49:03 PDT
Created attachment 311639 [details] Patch
Build Bot
Comment 5 2017-05-31 14:52:04 PDT
Attachment 311639 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ThreadGlobalData.h:39: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 6 2017-05-31 16:30:20 PDT
Comment on attachment 311639 [details] Patch r=me
Chris Dumez
Comment 7 2017-05-31 16:33:34 PDT
Comment on attachment 311639 [details] Patch Clearing flags on attachment: 311639 Committed r217639: <http://trac.webkit.org/changeset/217639>
Chris Dumez
Comment 8 2017-05-31 16:33:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.