Bug 172773

Summary:

Have a single ImageDecoder header file for all ports

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Images

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

NEW

Severity:

Normal

CC:

bfulgham, cgarcia, clopez, magomez, mjs, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	mjs: review-

Said Abou-Hallawa

Reported 2017-05-31 13:03:10 PDT

Currently we have three header files for the same class ImageDecoder: Source/WebCore/platform/image-decoders/ImageDecoder.h Source/WebCore/platform/graphics/cg/ImageDecoderCG.h Source/WebCore/platform/graphics/win/ImageDecoderDirect2D.h These files contains almost the same function prototypes with few differences which depend on how much the platform of the port supports image decoding. Having three header files for the same class has been annoying and error prone. Merging the three files into one file will make it easier to change a function prototype in this class.

Attachments
Patch (41.03 KB, patch) 2017-05-31 13:18 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (41.64 KB, patch) 2017-05-31 14:15 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (41.65 KB, patch) 2017-05-31 14:44 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (57.80 KB, patch) 2017-05-31 15:10 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (63.27 KB, patch) 2017-05-31 15:41 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (64.98 KB, patch) 2017-06-02 13:04 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (64.98 KB, patch) 2017-06-02 14:55 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (62.04 KB, patch) 2017-06-02 15:15 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (62.01 KB, patch) 2017-06-02 15:33 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (63.47 KB, patch) 2017-06-02 15:55 PDT, Said Abou-Hallawa	mjs: review-	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.