Bug 172759

Summary: Reland r216808, underlying lldb bug has been fixed.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: REOPENED    
Severity: Normal CC: achristensen, commit-queue, csaavedra, jralls, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172785    
Bug Blocks:    
Attachments:
Description Flags
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2017-05-31 10:23:43 PDT
Reland r216808, underlying lldb bug has been fixed.
Attachments
Patch for landing (48.81 KB, patch)
2017-05-31 10:24 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.90 KB, patch)
2017-05-31 10:38 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-05-31 10:24:54 PDT
Created attachment 311606 [details] Patch for landing
Keith Miller
Comment 2 2017-05-31 10:38:55 PDT
Created attachment 311608 [details] Patch for landing
WebKit Commit Bot
Comment 3 2017-05-31 11:16:56 PDT
Comment on attachment 311608 [details] Patch for landing Clearing flags on attachment: 311608 Committed r217611: <http://trac.webkit.org/changeset/217611>
WebKit Commit Bot
Comment 4 2017-05-31 11:16:58 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2017-05-31 16:22:04 PDT
Re-opened since this is blocked by bug 172785
Csaba Osztrogonác
Comment 6 2017-06-03 06:55:08 PDT
Relaned in http://trac.webkit.org/changeset/217669 which broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/threads/Signals.cpp:33:10: fatal error: 'MachExceptionsServer.h' file not found #include "MachExceptionsServer.h" ^
John Ralls
Comment 7 2017-10-08 11:30:17 PDT
Does it break the PLATFORM(MAC) cmake build or just the PLATFORM(GTK) one on Mac? On PlatformMac.cmake should generate MachExceptionsServer.h but that target isn't present in PlatformGtk.cmake. Changing Platform.h line 663 to #if __has_include(<mach/mach_exc.defs>) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV) || PLATFORM(GTK)) resolves the problem for Gtk builds.
Claudio Saavedra
Comment 8 2017-12-18 07:26:54 PST
FWIW I pushed this https://trac.webkit.org/changeset/226035 to fix (partially) the GTK+ build in Darwin.
Note You need to log in before you can comment on or make changes to this bug.