Bug 172757

Summary: [GTK][WPE] run-javascriptcore-tests should use the jhbuild
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, buildbot, calvaris, dbates, fpizlo, lforschler, simon.fraser, ysuzuki, zan
Priority: P1    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Carlos Alberto Lopez Perez
Reported 2017-05-31 09:01:51 PDT
It turns out that run-javascriptcore-tests is not using the jhbuild. This went undetected so far because the jsc binary don't links without that much libraries (pretty much only libicu). So this is currently not an issue for the WPE port as libicu is not included on the jhbuild. For the GTK+ port we are including it, and on Debian 8 the jsc binary included the rpath to the library so the linker was able to resolve the right path without needing the jhbuild trick of setting LD_LIBRARY_PATH. On Debian 9 it seems this is not longer the case (no idea why). In any case the fix is clear: run-javascriptcore-tests should use the jhbuild wrapper for the ports that use jhbuild. This is currently causing thousands of jsc test failures on the GTK+ bots (I upgraded them today to debian 9)
Attachments
Patch (2.19 KB, patch)
2017-05-31 09:05 PDT, Carlos Alberto Lopez Perez 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-05-31 09:05:20 PDT
Created attachment 311598 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-05-31 09:09:20 PDT
Comment on attachment 311598 [details] Patch Nit: it would be nice a quick explanation on the changelog
Carlos Alberto Lopez Perez
Comment 3 2017-05-31 09:14:09 PDT
Committed r217605: <http://trac.webkit.org/changeset/217605>
Note You need to log in before you can comment on or make changes to this bug.