Bug 172750

Summary:

[CMake] Do not pass -Wno-expansion-to-defined to Clang <4.0.0

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Tools / Tests

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, clopez, lforschler, mcatanzaro, zan

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Adrian Perez 2017-05-31 07:56:06 PDT

As per Carlos López's comment on bug #167643:

> I get thousands of warnings printed like this:
> warning: unknown warning option '-Wno-expansion-to-defined'; did you mean '-Wno-macro-redefined'? [-Wunknown-warning-option]
>
> Using clang-3.8 with ccache.

With Clang 4.0 there is no such warning.

Comment 1 Adrian Perez 2017-05-31 08:10:19 PDT

Created attachment 311589 [details]
Patch

Comment 2 Michael Catanzaro 2017-05-31 12:44:03 PDT

Comment on attachment 311589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311589&action=review

> Source/cmake/OptionsCommon.cmake:37
> +    if (NOT(COMPILER_IS_CLANG AND "${CLANG_VERSION}" VERSION_LESS 4.0.0))

Style: add one space after the NOT

Comment 3 Adrian Perez 2017-05-31 12:54:27 PDT

Committed r217618: <http://trac.webkit.org/changeset/217618>