Summary: | Make ResourceLoadStatistics testing more reliable | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, ap, bfulgham, jlewis3, lforschler, ryanhaddad, wilander | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2017-05-30 14:03:00 PDT
Created attachment 311574 [details]
Patch
Comment on attachment 311574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311574&action=review > Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:146 > + RunLoop::main().dispatch([this, protectedThis = makeRef(*this)] () mutable { > + WebProcessProxy::notifyPageStatisticsAndDataRecordsProcessed(); > + }); It's not obvious why `this` has to be captured here since the lambda calls a static function. Comment on attachment 311574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311574&action=review >> Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:146 >> + }); > > It's not obvious why `this` has to be captured here since the lambda calls a static function. Good point. I'll remove that and double-check before landing. Committed r217606: <http://trac.webkit.org/changeset/217606> |