Bug 172725

Summary: Dictionary lookup disappears after a few seconds on observer.com
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bdakin: review+

Description Tim Horton 2017-05-30 12:41:55 PDT 
Dictionary lookup disappears after a few seconds on observer.com
Comment 1 Tim Horton 2017-05-30 12:42:13 PDT 
Created attachment 311530 [details]
Patch
Comment 2 Tim Horton 2017-05-30 12:48:58 PDT 
Created attachment 311531 [details]
Patch
Comment 3 Tim Horton 2017-05-30 12:50:49 PDT 
The /ideal/ fix would involve tracking what frame each content-relative subwindow originated from, and dismissing it if that frame navigates, but that is a lot of bookkeeping for little value, when this fixes what is likely the most common case.
Comment 4 Tim Horton 2017-05-30 12:57:32 PDT 
http://trac.webkit.org/changeset/217566/webkit
Comment 5 Radar WebKit Bug Importer 2017-05-30 20:17:24 PDT 
<rdar://problem/32479621>
Comment 6 Alexey Proskuryakov 2017-05-31 22:24:29 PDT 
Shouldn't this be using the same code path as resetting input method state on navigation?

See also: rdar://problem/13875766