Bug 172712

Summary:

[css-align] Implement the new behavior of 'legacy' for justify-items

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, ews-watchlist, hyatt, jfernandez, koivisto, rego, rniwa, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugzilla.mozilla.org/show_bug.cgi?id=1363875
https://bugs.chromium.org/p/chromium/issues/detail?id=726148

Bug Depends on:

Bug Blocks:

172711

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews200 for win-future	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Patch	none

Javier Fernandez

Reported 2017-05-30 06:53:17 PDT

The 'auto' value, previously valid for the justify-items property, has been renamed to 'legacy': https://drafts.csswg.org/css-align/#valdef-justify-items-legacy

Attachments
Patch (52.23 KB, patch) 2018-02-06 07:25 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.27 MB, application/zip) 2018-02-06 08:37 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.59 MB, application/zip) 2018-02-06 08:38 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (2.95 MB, application/zip) 2018-02-06 09:08 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (11.56 MB, application/zip) 2018-02-06 09:46 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.23 MB, application/zip) 2018-02-06 11:06 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews200 for win-future (11.60 MB, application/zip) 2018-02-06 11:37 PST, EWS Watchlist	no flags	Details
Patch (58.67 KB, patch) 2018-02-06 13:44 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.19 MB, application/zip) 2018-02-06 14:54 PST, EWS Watchlist	no flags	Details
Patch (58.49 KB, patch) 2018-02-06 15:01 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2018-01-29 03:02:46 PST

I'm working on this now.

Javier Fernandez

Comment 2 2018-02-06 07:25:30 PST

Created attachment 333173 [details] Patch

EWS Watchlist

Comment 3 2018-02-06 07:28:06 PST

Attachment 333173 [details] did not pass style-queue: ERROR: Source/WebCore/css/StyleResolver.cpp:1067: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2018-02-06 08:37:33 PST

Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6383049 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html

EWS Watchlist

Comment 5 2018-02-06 08:37:35 PST

Created attachment 333176 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-02-06 08:38:48 PST

Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6383045 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html

EWS Watchlist

Comment 7 2018-02-06 08:38:50 PST

Created attachment 333177 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-02-06 09:08:21 PST

Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6383095 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html

EWS Watchlist

Comment 9 2018-02-06 09:08:22 PST

Created attachment 333180 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-02-06 09:45:49 PST

Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6383501 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html

EWS Watchlist

Comment 11 2018-02-06 09:46:00 PST

Created attachment 333183 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 12 2018-02-06 11:05:58 PST

Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6384217 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html

EWS Watchlist

Comment 13 2018-02-06 11:06:00 PST

Created attachment 333192 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-02-06 11:37:29 PST

Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6384733 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html

EWS Watchlist

Comment 15 2018-02-06 11:37:40 PST

Created attachment 333197 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Javier Fernandez

Comment 16 2018-02-06 13:44:24 PST

Created attachment 333210 [details] Patch

EWS Watchlist

Comment 17 2018-02-06 14:54:20 PST

Comment on attachment 333210 [details] Patch Attachment 333210 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6387803 New failing tests: css3/parse-place-items.html

EWS Watchlist

Comment 18 2018-02-06 14:54:22 PST

Created attachment 333221 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Javier Fernandez

Comment 19 2018-02-06 15:01:26 PST

Created attachment 333223 [details] Patch

WebKit Commit Bot

Comment 20 2018-02-09 06:57:18 PST

Comment on attachment 333223 [details] Patch Clearing flags on attachment: 333223 Committed r228319: <https://trac.webkit.org/changeset/228319>

WebKit Commit Bot

Comment 21 2018-02-09 06:57:20 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 22 2018-02-09 06:59:56 PST

<rdar://problem/37389693>

Note You need to log in before you can comment on or make changes to this bug.