Summary: | [css-align] Implement the new behavior of 'legacy' for justify-items | ||
---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> |
Component: | CSS | Assignee: | Javier Fernandez <jfernandez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | cdumez, commit-queue, darin, ews-watchlist, hyatt, jfernandez, koivisto, rego, rniwa, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugzilla.mozilla.org/show_bug.cgi?id=1363875 https://bugs.chromium.org/p/chromium/issues/detail?id=726148 |
||
Bug Depends on: | |||
Bug Blocks: | 172711 | ||
Attachments: |
Description
Javier Fernandez
2017-05-30 06:53:17 PDT
I'm working on this now. Created attachment 333173 [details]
Patch
Attachment 333173 [details] did not pass style-queue:
ERROR: Source/WebCore/css/StyleResolver.cpp:1067: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6383049 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html Created attachment 333176 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6383045 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html Created attachment 333177 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6383095 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html Created attachment 333180 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6383501 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html Created attachment 333183 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6384217 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html Created attachment 333192 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 333173 [details] Patch Attachment 333173 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6384733 New failing tests: css3/parse-alignment-of-root-elements.html css3/parse-place-items.html fast/css/parse-justify-items.html Created attachment 333197 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 333210 [details]
Patch
Comment on attachment 333210 [details] Patch Attachment 333210 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6387803 New failing tests: css3/parse-place-items.html Created attachment 333221 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 333223 [details]
Patch
Comment on attachment 333223 [details] Patch Clearing flags on attachment: 333223 Committed r228319: <https://trac.webkit.org/changeset/228319> All reviewed patches have been landed. Closing bug. |