Bug 172691

Summary:

[Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES

Product:

WebKit

Reporter:

mitz

Component:

New Bugs

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, berto, buildbot, cgarcia, csaavedra, dino, graouts, gustavo, keith_miller, kondapallykalyan, mark.lam, mcatanzaro, msaboff, ossy, saam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214613

Attachments:

Description	Flags
Set ALWAYS_SEARCH_USER_PATHS to NO	none
Set ALWAYS_SEARCH_USER_PATHS to NO	none
Set ALWAYS_SEARCH_USER_PATHS to NO	thorton: review+

mitz

Reported 2017-05-28 20:33:56 PDT

While ALWAYS_SEARCH_USER_PATHS defaults to YES if never defined, the default for new projects has been NO for several major Xcode releases, and the behavior of ALWAYS_SEARCH_USER_PATHS = YES is considered undesirable. Projects should attempt to migrate to using ALWAYS_SEARCH_USER_PATHS = NO exclusively where possible.

Attachments
Set ALWAYS_SEARCH_USER_PATHS to NO (35.00 KB, patch) 2017-05-28 21:26 PDT, mitz	no flags	Details Formatted Diff Diff
Set ALWAYS_SEARCH_USER_PATHS to NO (35.54 KB, patch) 2017-05-28 21:31 PDT, mitz	no flags	Details Formatted Diff Diff
Set ALWAYS_SEARCH_USER_PATHS to NO (36.99 KB, patch) 2017-05-28 21:47 PDT, mitz	thorton: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2017-05-28 21:26:37 PDT

Created attachment 311452 [details] Set ALWAYS_SEARCH_USER_PATHS to NO

Build Bot

Comment 2 2017-05-28 21:29:21 PDT

Attachment 311452 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 3 2017-05-28 21:31:23 PDT

Created attachment 311453 [details] Set ALWAYS_SEARCH_USER_PATHS to NO

Build Bot

Comment 4 2017-05-28 21:34:21 PDT

Attachment 311453 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:29: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 5 2017-05-28 21:47:07 PDT

Created attachment 311454 [details] Set ALWAYS_SEARCH_USER_PATHS to NO

Build Bot

Comment 6 2017-05-28 21:49:21 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Build Bot

Comment 7 2017-05-28 21:49:31 PDT

Attachment 311454 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 8 2017-05-28 22:31:12 PDT

Fixed in <https://trac.webkit.org/r217531>.

Claudio Saavedra

Comment 9 2017-05-29 01:44:10 PDT

This broke WPE. Build fix in http://trac.webkit.org/changeset/217533

Csaba Osztrogonác

Comment 10 2017-05-29 03:11:27 PDT

(In reply to mitz from comment #8) > Fixed in <https://trac.webkit.org/r217531>. FYI, it broke the Apple Mac cmake build, see https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/2025

Radar WebKit Bug Importer

Comment 11 2017-05-30 20:19:08 PDT

<rdar://problem/32479643>

Note You need to log in before you can comment on or make changes to this bug.