| Summary: | [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||||
| Component: | New Bugs | Assignee: | mitz | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, berto, buildbot, cgarcia, csaavedra, dino, graouts, gustavo, keith_miller, kondapallykalyan, mark.lam, mcatanzaro, msaboff, ossy, saam, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214613 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
mitz
2017-05-28 20:33:56 PDT
Created attachment 311452 [details]
Set ALWAYS_SEARCH_USER_PATHS to NO
Attachment 311452 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 38 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 311453 [details]
Set ALWAYS_SEARCH_USER_PATHS to NO
Attachment 311453 [details] did not pass style-queue:
ERROR: Source/WebKit2/ChangeLog:29: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 39 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 311454 [details]
Set ALWAYS_SEARCH_USER_PATHS to NO
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Attachment 311454 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 38 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Fixed in <https://trac.webkit.org/r217531>. This broke WPE. Build fix in http://trac.webkit.org/changeset/217533 (In reply to mitz from comment #8) > Fixed in <https://trac.webkit.org/r217531>. FYI, it broke the Apple Mac cmake build, see https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/2025 |