Bug 172690

Summary: [JSC] Provide better type information of toLength and tighten bytecode
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 153738    
Attachments:
Description Flags
Patch sam: review+

Yusuke Suzuki
Reported 2017-05-28 19:31:00 PDT
[JSC] Provide better type information of toLength and tighten bytecode
Attachments
Patch (3.59 KB, patch)
2017-05-28 19:39 PDT, Yusuke Suzuki 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-05-28 19:39:10 PDT
Created attachment 311449 [details] Patch
Sam Weinig
Comment 2 2017-05-28 21:57:28 PDT
Comment on attachment 311449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311449&action=review > Source/JavaScriptCore/ChangeLog:15 > + operator+ emits to_number bytecode. What this bytecode does is the same > + to @Number() call. It is more efficient, and it is smaller bytecode > + than @Number() call (load global variable @Number, set up arguments, and > + call it). Should we remove @Number()? Alternatively, should we make @Number() transform into to_number (maybe via your bytecode re-writer )?
Yusuke Suzuki
Comment 3 2017-05-28 22:08:09 PDT
Comment on attachment 311449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311449&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:15 >> + call it). > > Should we remove @Number()? Alternatively, should we make @Number() transform into to_number (maybe via your bytecode re-writer )? I've just checked and found some WebCore code still uses @Number(). Maybe, they also can be converted to +. Filed it separately https://bugs.webkit.org/show_bug.cgi?id=172692.
Yusuke Suzuki
Comment 4 2017-05-28 22:09:21 PDT
Committed r217530: <http://trac.webkit.org/changeset/217530>
Radar WebKit Bug Importer
Comment 5 2017-05-30 20:19:32 PDT
<rdar://problem/32479650>
Note You need to log in before you can comment on or make changes to this bug.