Bug 172662

Summary: Multiple failures from http/tests/cache/disk-cache/ Layout Tests
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ap, ben_schwartz, ggaren, jacob_uphoff, koivisto, Lawrence.j, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=149087

Description Matt Lewis 2017-05-26 13:30:19 PDT
Twice now I have seen multiple test from http/tests/cache/disk-cache/ failing:

http/tests/cache/disk-cache/disk-cache-204-status-code.html 
http/tests/cache/disk-cache/disk-cache-307-status-code.html 
http/tests/cache/disk-cache/disk-cache-404-status-code.html 
http/tests/cache/disk-cache/disk-cache-disable.html
http/tests/cache/disk-cache/disk-cache-last-modified.html
http/tests/cache/disk-cache/disk-cache-media.html
http/tests/cache/disk-cache/disk-cache-range.html
http/tests/cache/disk-cache/disk-cache-redirect.html
http/tests/cache/disk-cache/disk-cache-request-headers.html
http/tests/cache/disk-cache/disk-cache-request-max-stale.html
http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html
http/tests/cache/disk-cache/disk-cache-validation-attachment.html
http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html
http/tests/cache/disk-cache/disk-cache-vary-cookie.html
http/tests/cache/disk-cache/disk-cache-vary-no-body.html
http/tests/cache/disk-cache/disk-cache-vary.html
http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html
http/tests/cache/disk-cache/redirect-chain-limits.html
http/tests/cache/disk-cache/resource-becomes-uncacheable.html

It has happened on two different trains, two different bots and two different configurations.

I have yet to be able to reliably reproduce the issue on either El Capitan or Sierra.
The test are fairly flaky, but they usually fail together.


https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1223
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/1769
Comment 1 Alexey Proskuryakov 2017-05-30 17:28:34 PDT
On the surface, this sounds much like bug 149087, but the fact that multiple tests fail at once is a difference.
Comment 2 Matt Lewis 2017-06-08 14:22:11 PDT
I was able to reproduce a similar failure locally with test http/tests/cache/disk-cache/disk-cache-302-status-code.html

I used run-webkit-tests http/tests/cache/disk-cache --no-retry-failures --iterations=10

The tests are very flaky so it doesn't always trigger. 

diff:
--- /Users/mattlewis/buildtotest/layout-test-results/http/tests/cache/disk-cache/disk-cache-302-status-code-expected.txt
+++ /Users/mattlewis/buildtotest/layout-test-results/http/tests/cache/disk-cache/disk-cache-302-status-code-actual.txt
@@ -10,7 +10,7 @@
 response source: Network
 
 response headers: {"Status":"302","Location":"/","Cache-control":"max-age=100"}
-response source: Network
+response source: Disk cache
 
 --------Testing loads through memory cache (XHR behavior)--------
 response headers: {"Status":"302","Location":"/","Cache-control":"max-age=0"}
Comment 3 Ryan Haddad 2017-06-22 10:40:05 PDT
This is still happening: 
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/2467

http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-validation-attachment.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-vary-cookie.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-vary.html [ Failure ]
http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html [ Failure ]
http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
http/tests/cache/disk-cache/resource-becomes-uncacheable.html [ Failure ]
Comment 4 Radar WebKit Bug Importer 2017-06-22 10:40:36 PDT
<rdar://problem/32927322>
Comment 5 Matt Lewis 2017-07-18 14:31:08 PDT
The test http/tests/cache/disk-cache/disk-cache-vary-cookie.html is now failing with http/tests/cache/disk-cache/redirect-chain-limits.html only

Marked http/tests/cache/disk-cache/disk-cache-vary-cookie.html as flaky in:
https://trac.webkit.org/changeset/219627/webkit

Marked http/tests/cache/disk-cache/redirect-chain-limits.html as flaky in:
https://trac.webkit.org/changeset/219629/webkit
Comment 6 Ben Schwartz 2024-01-25 12:54:50 PST
This appears resolved. Removing test expectations to restore test coverage.
Comment 7 Ben Schwartz 2024-01-25 12:58:46 PST
*** Bug 162685 has been marked as a duplicate of this bug. ***
Comment 8 Ben Schwartz 2024-01-25 13:01:49 PST
*** Bug 149087 has been marked as a duplicate of this bug. ***
Comment 9 Ben Schwartz 2024-01-25 13:04:34 PST
*** Bug 162524 has been marked as a duplicate of this bug. ***
Comment 10 Ben Schwartz 2024-01-25 13:05:54 PST
*** Bug 164594 has been marked as a duplicate of this bug. ***
Comment 11 Ben Schwartz 2024-01-25 13:07:01 PST
*** Bug 159840 has been marked as a duplicate of this bug. ***
Comment 12 Ben Schwartz 2024-01-25 13:11:24 PST
*** Bug 179796 has been marked as a duplicate of this bug. ***
Comment 13 Ben Schwartz 2024-01-25 13:24:56 PST
*** Bug 207770 has been marked as a duplicate of this bug. ***
Comment 14 Ben Schwartz 2024-01-25 13:47:44 PST
*** Bug 209512 has been marked as a duplicate of this bug. ***
Comment 15 Ben Schwartz 2024-01-25 14:05:54 PST
*** Bug 162975 has been marked as a duplicate of this bug. ***