Bug 172662
| Summary: | Multiple failures from http/tests/cache/disk-cache/ Layout Tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, ben_schwartz, ggaren, jacob_uphoff, koivisto, Lawrence.j, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=149087 | ||
Matt Lewis
Twice now I have seen multiple test from http/tests/cache/disk-cache/ failing:
http/tests/cache/disk-cache/disk-cache-204-status-code.html
http/tests/cache/disk-cache/disk-cache-307-status-code.html
http/tests/cache/disk-cache/disk-cache-404-status-code.html
http/tests/cache/disk-cache/disk-cache-disable.html
http/tests/cache/disk-cache/disk-cache-last-modified.html
http/tests/cache/disk-cache/disk-cache-media.html
http/tests/cache/disk-cache/disk-cache-range.html
http/tests/cache/disk-cache/disk-cache-redirect.html
http/tests/cache/disk-cache/disk-cache-request-headers.html
http/tests/cache/disk-cache/disk-cache-request-max-stale.html
http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html
http/tests/cache/disk-cache/disk-cache-validation-attachment.html
http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html
http/tests/cache/disk-cache/disk-cache-vary-cookie.html
http/tests/cache/disk-cache/disk-cache-vary-no-body.html
http/tests/cache/disk-cache/disk-cache-vary.html
http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html
http/tests/cache/disk-cache/redirect-chain-limits.html
http/tests/cache/disk-cache/resource-becomes-uncacheable.html
It has happened on two different trains, two different bots and two different configurations.
I have yet to be able to reliably reproduce the issue on either El Capitan or Sierra.
The test are fairly flaky, but they usually fail together.
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1223
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/1769
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
On the surface, this sounds much like bug 149087, but the fact that multiple tests fail at once is a difference.
Matt Lewis
I was able to reproduce a similar failure locally with test http/tests/cache/disk-cache/disk-cache-302-status-code.html
I used run-webkit-tests http/tests/cache/disk-cache --no-retry-failures --iterations=10
The tests are very flaky so it doesn't always trigger.
diff:
--- /Users/mattlewis/buildtotest/layout-test-results/http/tests/cache/disk-cache/disk-cache-302-status-code-expected.txt
+++ /Users/mattlewis/buildtotest/layout-test-results/http/tests/cache/disk-cache/disk-cache-302-status-code-actual.txt
@@ -10,7 +10,7 @@
response source: Network
response headers: {"Status":"302","Location":"/","Cache-control":"max-age=100"}
-response source: Network
+response source: Disk cache
--------Testing loads through memory cache (XHR behavior)--------
response headers: {"Status":"302","Location":"/","Cache-control":"max-age=0"}
Ryan Haddad
This is still happening:
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/2467
http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-validation-attachment.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-vary-cookie.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Failure ]
http/tests/cache/disk-cache/disk-cache-vary.html [ Failure ]
http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html [ Failure ]
http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
http/tests/cache/disk-cache/resource-becomes-uncacheable.html [ Failure ]
Radar WebKit Bug Importer
<rdar://problem/32927322>
Matt Lewis
The test http/tests/cache/disk-cache/disk-cache-vary-cookie.html is now failing with http/tests/cache/disk-cache/redirect-chain-limits.html only
Marked http/tests/cache/disk-cache/disk-cache-vary-cookie.html as flaky in:
https://trac.webkit.org/changeset/219627/webkit
Marked http/tests/cache/disk-cache/redirect-chain-limits.html as flaky in:
https://trac.webkit.org/changeset/219629/webkit
Ben Schwartz
This appears resolved. Removing test expectations to restore test coverage.
Ben Schwartz
*** Bug 162685 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 149087 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 162524 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 164594 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 159840 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 179796 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 207770 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 209512 has been marked as a duplicate of this bug. ***
Ben Schwartz
*** Bug 162975 has been marked as a duplicate of this bug. ***