Bug 172659

Summary:

RealtimeOutgoingVideoSource should not rotate muted frames

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, jonlee, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch for landing	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Fixing win and adding expectation for test	none

youenn fablet

Reported 2017-05-26 13:13:56 PDT

Instead, the size should be set correctly.

Attachments
Patch (19.40 KB, patch) 2017-05-26 14:44 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (922.30 KB, application/zip) 2017-05-26 15:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (21.57 MB, application/zip) 2017-05-26 16:07 PDT, Build Bot	no flags	Details
Patch for landing (20.40 KB, patch) 2017-05-30 09:34 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (859.36 KB, application/zip) 2017-05-30 10:39 PDT, Build Bot	no flags	Details
Fixing win and adding expectation for test (21.35 KB, patch) 2017-05-30 10:51 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-05-26 14:44:41 PDT

Created attachment 311378 [details] Patch

Radar WebKit Bug Importer

Comment 2 2017-05-26 14:45:22 PDT

<rdar://problem/32434268>

youenn fablet

Comment 3 2017-05-26 14:45:35 PDT

This should probably take care of many crashes we saw on iOS.

Build Bot

Comment 4 2017-05-26 15:39:08 PDT

Comment on attachment 311378 [details] Patch Attachment 311378 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3823909 New failing tests: webrtc/video-rotation.html

Build Bot

Comment 5 2017-05-26 15:39:09 PDT

Created attachment 311385 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-05-26 16:07:00 PDT

Comment on attachment 311378 [details] Patch Attachment 311378 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3823944 New failing tests: webrtc/video-rotation.html fast/css/target-fragment-match.html

Build Bot

Comment 7 2017-05-26 16:07:02 PDT

Created attachment 311391 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

youenn fablet

Comment 8 2017-05-30 09:34:44 PDT

Created attachment 311511 [details] Patch for landing

youenn fablet

Comment 9 2017-05-30 09:35:33 PDT

(In reply to youenn fablet from comment #8) > Created attachment 311511 [details] > Patch for landing Updated test to return promise in waitForSize.

Build Bot

Comment 10 2017-05-30 10:39:21 PDT

Comment on attachment 311511 [details] Patch for landing Attachment 311511 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3842807 New failing tests: webrtc/video-rotation.html

Build Bot

Comment 11 2017-05-30 10:39:22 PDT

Created attachment 311516 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

youenn fablet

Comment 12 2017-05-30 10:51:53 PDT

Created attachment 311518 [details] Fixing win and adding expectation for test

WebKit Commit Bot

Comment 13 2017-05-30 11:29:16 PDT

Comment on attachment 311518 [details] Fixing win and adding expectation for test Clearing flags on attachment: 311518 Committed r217562: <http://trac.webkit.org/changeset/217562>

WebKit Commit Bot

Comment 14 2017-05-30 11:29:18 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.