Bug 172625

Summary: Gracefully handle missing localStorage support in results.html
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, cdumez, commit-queue, lforschler, ryanhaddad, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2017-05-25 17:21:26 PDT
The 'results.html' file displays test output, and provides local storage of user settings as a convenience. If localStorage is blocked due to security settings, the page throws SecurityError DOMExceptions, and shows all test failures (including those that are expected) making it difficult to review test results. This patch makes missing localStorage a non-fatal error, using the default settings if it cannot load (or save) customizations made by the user.
Attachments
Patch (1.76 KB, patch)
2017-05-25 17:25 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-05-25 17:21:35 PDT
<rdar://problem/32118243>
Brent Fulgham
Comment 2 2017-05-25 17:25:22 PDT
Created attachment 311320 [details] Patch
Alexey Proskuryakov
Comment 3 2017-05-25 18:40:37 PDT
Comment on attachment 311320 [details] Patch r=me, assuming that it fixes the issue.
WebKit Commit Bot
Comment 4 2017-05-25 19:56:15 PDT
Comment on attachment 311320 [details] Patch Clearing flags on attachment: 311320 Committed r217470: <http://trac.webkit.org/changeset/217470>
WebKit Commit Bot
Comment 5 2017-05-25 19:56:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.