Bug 172621

Summary:

Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, timothy

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

172393

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	timothy: review+
Patch	none

Description Devin Rousso 2017-05-25 16:21:40 PDT

Currently, each of these classes are constructed when the related TabContentView is constructed, which all happen when the TabBrowser loads the open tabs from settings.  Instead, they should only be created once a tab that requires it is shown.

Comment 1 Devin Rousso 2017-05-25 16:33:11 PDT

Created attachment 311314 [details]
Patch

Comment 2 Devin Rousso 2017-05-25 18:35:07 PDT

Created attachment 311323 [details]
Patch

Comment 3 Timothy Hatcher 2017-06-02 10:09:02 PDT

Comment on attachment 311323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311323&action=review

Looks good.

> Source/WebInspectorUI/UserInterface/Views/TabContentView.js:182
>      get navigationSidebarCollapsedSetting() { return this._navigationSidebarCollapsedSetting; }

Add a new line above since the new getter is not a single line.

Comment 4 Devin Rousso 2017-06-02 20:06:34 PDT

Created attachment 311901 [details]
Patch

Comment 5 WebKit Commit Bot 2017-06-02 20:44:55 PDT

Comment on attachment 311901 [details]
Patch

Clearing flags on attachment: 311901

Committed r217750: <http://trac.webkit.org/changeset/217750>

Comment 6 WebKit Commit Bot 2017-06-02 20:44:56 PDT

All reviewed patches have been landed.  Closing bug.