Bug 172617

Summary: The default setting of Option::criticalGCMemoryThreshold is too high for iOS
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ggaren, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2017-05-25 15:59:27 PDT
When testing on iOS, the current default value for Option::criticalGCMemoryThreshold of 0.88 led to jetsams. No jetsams are observed with a value of 0.80.
Attachments
Patch (1.74 KB, patch)
2017-05-25 16:19 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2017-05-25 16:19:58 PDT
Created attachment 311309 [details] Patch
Mark Lam
Comment 2 2017-05-25 16:24:28 PDT
Comment on attachment 311309 [details] Patch rs=me
Geoffrey Garen
Comment 3 2017-05-25 16:24:49 PDT
Comment on attachment 311309 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-05-25 17:03:15 PDT
Comment on attachment 311309 [details] Patch Clearing flags on attachment: 311309 Committed r217457: <http://trac.webkit.org/changeset/217457>
WebKit Commit Bot
Comment 5 2017-05-25 17:03:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-05-30 20:21:32 PDT
<rdar://problem/32479720>
Saam Barati
Comment 7 2017-06-14 11:40:03 PDT
It looks like this or https://bugs.webkit.org/show_bug.cgi?id=172373 is a 1.5% slowdown on JetStream on iOS.
Note You need to log in before you can comment on or make changes to this bug.