| Summary: | [css-grid] Margin wrong applied when stretching an orthogonal item in fixed size track | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, jfernandez, rego, simon.fraser, svillar, zalan | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=725903 | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 60731 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 311219 [details]
Example to reproduce the issue
Created attachment 311220 [details]
Current output
This issue doesn't look like the same reported in Blink. In this case, the margins are not computed properly even avoiding repeating the grid layout logic, which was the cause of the Blink's issue. Created attachment 311763 [details]
Patch
Comment on attachment 311763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311763&action=review > Source/WebCore/ChangeLog:11 > + The issue this CL fixes is only reproducible when the grid layout logic CL is not common in WebKit, use patch/change... Created attachment 311808 [details]
Patch
Comment on attachment 311808 [details] Patch Clearing flags on attachment: 311808 Committed r217705: <http://trac.webkit.org/changeset/217705> All reviewed patches have been landed. Closing bug. |
Created attachment 311218 [details] Example to reproduce the issue Margin is wrongly computed when applied to an orthogonal item inside a fixed size track.