Bug 17259

Summary: Element::recalcStyle() needlessly null-checks the result of styleForElement()
Product: WebKit Reporter: mitz
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Remove unneeded null checks sam: review+

mitz
Reported 2008-02-09 10:56:44 PST
Element::recalcStyle() needlessly null-checks the result of styleForElement().
Attachments
Remove unneeded null checks (1.92 KB, patch)
2008-02-09 10:58 PST, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2008-02-09 10:58:09 PST
Created attachment 19019 [details] Remove unneeded null checks
Sam Weinig
Comment 2 2008-02-09 15:58:12 PST
Comment on attachment 19019 [details] Remove unneeded null checks This looks good to me, but as discussed, a better word than redundant should be used to describe why the null checks aren't needed. Just stating that styleForElement() cannot return null should be sufficient.
mitz
Comment 3 2008-02-09 16:17:05 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/30117>.
Note You need to log in before you can comment on or make changes to this bug.