Bug 172576 – ASSERTION FAILED: !needsStyleRecalc() || !document().childNeedsStyleRecalc()

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

LayoutTest/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html

rdar://problem/32181979

[alan]

Created attachment 311198 [details]
Patch

[alan]

Created attachment 311222 [details]
Patch

[Brent Fulgham]

Comment on attachment 311222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311222&action=review

> Source/WebCore/page/FocusController.cpp:383
> +        owner.contentFrame()->document()->updateLayoutIgnorePendingStylesheets();

It seems like moving the "owner.contentFrame()->document()" test here would prevent this patch from changing behavior for cases where there is no document.

Was it wrong in the existing code that frames without documents were running the remainder of this function?

If not, this change seems to do more than ensure that the layout is updated.

[Build Bot]

Comment on attachment 311222 [details]
Patch

Attachment 311222 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3814731

New failing tests:
fast/events/before-unload-returnValue.html
compositing/masks/compositing-clip-path-change-no-repaint.html
fast/css/target-fragment-match.html

[Build Bot]

Created attachment 311232 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[alan]

(In reply to Build Bot from comment #4)
> Comment on attachment 311222 [details]
> Patch
> 
> Attachment 311222 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/3814731
> 
> New failing tests:
> fast/events/before-unload-returnValue.html
> compositing/masks/compositing-clip-path-change-no-repaint.html
> fast/css/target-fragment-match.html
They look unrelated.

[WebKit Commit Bot]

Comment on attachment 311222 [details]
Patch

Clearing flags on attachment: 311222

Committed r217441: <http://trac.webkit.org/changeset/217441>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.