Bug 172546

Summary: [WK2] Remove workaround to disable zooming to the focus rect while performing a data interaction
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, commit-queue, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Wenson Hsieh 2017-05-24 10:30:16 PDT
Remove a now-unnecessary workaround to prevent scrolling when performing a data interaction operation in editable content.
Comment 1 Wenson Hsieh 2017-05-24 10:36:44 PDT
Created attachment 311130 [details]
Patch
Comment 2 Build Bot 2017-05-24 10:39:03 PDT
Attachment 311130 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1149:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1151:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1152:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1153:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1154:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1155:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-05-24 11:38:56 PDT
Comment on attachment 311130 [details]
Patch

Clearing flags on attachment: 311130

Committed r217375: <http://trac.webkit.org/changeset/217375>
Comment 4 WebKit Commit Bot 2017-05-24 11:38:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Wenson Hsieh 2017-05-24 11:47:36 PDT
<rdar://problem/31949588>
Comment 6 Radar WebKit Bug Importer 2017-05-30 20:24:06 PDT
<rdar://problem/32479771>