Bug 172546

Summary: [WK2] Remove workaround to disable zooming to the focus rect while performing a data interaction
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, commit-queue, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2017-05-24 10:30:16 PDT
Remove a now-unnecessary workaround to prevent scrolling when performing a data interaction operation in editable content.
Attachments
Patch (3.48 KB, patch)
2017-05-24 10:36 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-05-24 10:36:44 PDT
Created attachment 311130 [details] Patch
Build Bot
Comment 2 2017-05-24 10:39:03 PDT
Attachment 311130 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1150: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1155: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-05-24 11:38:56 PDT
Comment on attachment 311130 [details] Patch Clearing flags on attachment: 311130 Committed r217375: <http://trac.webkit.org/changeset/217375>
WebKit Commit Bot
Comment 4 2017-05-24 11:38:57 PDT
All reviewed patches have been landed. Closing bug.
Wenson Hsieh
Comment 5 2017-05-24 11:47:36 PDT
<rdar://problem/31949588>
Radar WebKit Bug Importer
Comment 6 2017-05-30 20:24:06 PDT
<rdar://problem/32479771>
Note You need to log in before you can comment on or make changes to this bug.