Bug 172535

Summary: [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit Misc.Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, pvollan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172485    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2017-05-23 22:08:51 PDT
WinCairo build are broken since Bug 172485. > source\webkit\win\webcoresupport\AcceleratedCompositingContext.h(55): error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
Attachments
Patch (2.70 KB, patch)
2017-05-23 23:01 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-05-23 22:41:45 PDT
Probably need to add a GraphicsLayerPaintFlags as the last argument. With no EWS, I did not see this before committing.
Fujii Hironori
Comment 2 2017-05-23 23:01:37 PDT
Created attachment 311101 [details] Patch Thank you.
WebKit Commit Bot
Comment 3 2017-05-24 02:50:24 PDT
Comment on attachment 311101 [details] Patch Clearing flags on attachment: 311101 Committed r217360: <http://trac.webkit.org/changeset/217360>
WebKit Commit Bot
Comment 4 2017-05-24 02:50:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-05-30 20:25:30 PDT
<rdar://problem/32479805>
Note You need to log in before you can comment on or make changes to this bug.