Bug 172535

Summary: [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit Misc.Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, pvollan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172485    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2017-05-23 22:08:51 PDT
WinCairo build are broken since Bug 172485.

> source\webkit\win\webcoresupport\AcceleratedCompositingContext.h(55): error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
Comment 1 Simon Fraser (smfr) 2017-05-23 22:41:45 PDT
Probably need to add a GraphicsLayerPaintFlags as the last argument.

With no EWS, I did not see this before committing.
Comment 2 Fujii Hironori 2017-05-23 23:01:37 PDT
Created attachment 311101 [details]
Patch

Thank you.
Comment 3 WebKit Commit Bot 2017-05-24 02:50:24 PDT
Comment on attachment 311101 [details]
Patch

Clearing flags on attachment: 311101

Committed r217360: <http://trac.webkit.org/changeset/217360>
Comment 4 WebKit Commit Bot 2017-05-24 02:50:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-05-30 20:25:30 PDT
<rdar://problem/32479805>