Bug 172521

Summary: [WK2 ] Layout Test imported/w3c/web-platform-tests/webrtc/getstats.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jacob_uphoff, rackler, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170818
Attachments:
Description Flags
Patch none

Description Matt Lewis 2017-05-23 13:51:48 PDT
The test imported/w3c/web-platform-tests/webrtc/getstats.html is a flaky failure on WK2.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2Fgetstats.html

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/1299
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r217283%20(1299)/results.html

diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webrtc/getstats-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webrtc/getstats-actual.txt
@@ -1,11 +1,22 @@
 
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT Can get stats from a basic WebRTC call. Test timed out
+FAIL Can get stats from a basic WebRTC call. assert_unreached: Error: assert_not_equals: Did not find peer-connection stats got disallowed value null:  Reached unreachable code
 Retrieved stats info
 
   
+{
+  "RTCDataChannel_1": {
+    "id": "RTCDataChannel_1",
+    "timestamp": 1495566495751658,
+    "type": "data-channel",
+    "bytesReceived": 0,
+    "bytesSent": 0,
+    "datachannelid": 1,
+    "label": "channel",
+    "messagesReceived": 0,
+    "messagesSent": 0,
+    "protocol": "",
+    "state": "open"
+  }
+}
 
   
-
-
Comment 1 Matt Lewis 2017-05-23 14:00:03 PDT
Marked test as flaky in https://trac.webkit.org/changeset/217299/webkit.
Comment 2 Karl Rackler 2020-06-29 13:07:38 PDT
imported/w3c/web-platform-tests/webrtc/getstats.html is no longer failing - remove expectations

Current history is green: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2Fgetstats.html
Comment 3 Karl Rackler 2020-06-29 13:10:13 PDT
Created attachment 403102 [details]
Patch
Comment 4 EWS 2020-06-29 13:48:14 PDT
Committed r263689: <https://trac.webkit.org/changeset/263689>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403102 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-29 13:48:49 PDT
<rdar://problem/64906032>