Bug 172496

Summary: [WPE] Use AcceleratedDrawingArea instead of its fork
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, yoon, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172642    
Bug Blocks:    
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2017-05-23 02:23:00 PDT
WPE uses its own drawing area implementation, which is actually a fork of AcceleratedDrawingArea, but simplified for the case of compositing being always forced. AcceleratedDrawingArea already handles the case of compositing being forced, so now that WPE is upstream we could simply use AcceleratedDrawingArea instead.
Attachments
Patch (24.40 KB, patch)
2017-05-23 02:26 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-05-23 02:26:51 PDT
Created attachment 310988 [details] Patch
Gwang Yoon Hwang
Comment 2 2017-05-23 03:53:15 PDT
Comment on attachment 310988 [details] Patch I'm really okay for this change!
Carlos Garcia Campos
Comment 3 2017-05-26 01:07:40 PDT
Committed r217479: <http://trac.webkit.org/changeset/217479>
WebKit Commit Bot
Comment 4 2017-05-26 06:25:56 PDT
Re-opened since this is blocked by bug 172642
Zan Dobersek
Comment 5 2017-06-05 00:16:05 PDT
This is now fine to land with the forceRepaint() being made exclusive to PLATFORM(GTK).
Carlos Garcia Campos
Comment 6 2017-06-05 05:02:07 PDT
Committed r217779: <http://trac.webkit.org/changeset/217779>
Note You need to log in before you can comment on or make changes to this bug.