Bug 172496

Summary: [WPE] Use AcceleratedDrawingArea instead of its fork
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, yoon, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172642    
Bug Blocks:    
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2017-05-23 02:23:00 PDT 
WPE uses its own drawing area implementation, which is actually a fork of AcceleratedDrawingArea, but simplified for the case of compositing being always forced. AcceleratedDrawingArea already handles the case of compositing being forced, so now that WPE is upstream we could simply use AcceleratedDrawingArea instead.
Comment 1 Carlos Garcia Campos 2017-05-23 02:26:51 PDT 
Created attachment 310988 [details]
Patch
Comment 2 Gwang Yoon Hwang 2017-05-23 03:53:15 PDT 
Comment on attachment 310988 [details]
Patch

I'm really okay for this change!
Comment 3 Carlos Garcia Campos 2017-05-26 01:07:40 PDT 
Committed r217479: <http://trac.webkit.org/changeset/217479>
Comment 4 WebKit Commit Bot 2017-05-26 06:25:56 PDT 
Re-opened since this is blocked by bug 172642
Comment 5 Zan Dobersek 2017-06-05 00:16:05 PDT 
This is now fine to land with the forceRepaint() being made exclusive to PLATFORM(GTK).
Comment 6 Carlos Garcia Campos 2017-06-05 05:02:07 PDT 
Committed r217779: <http://trac.webkit.org/changeset/217779>