Bug 172485 – Snapshotting via -renderInContext: should do synchronous image decodes

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Snapshotting via -renderInContext: should do synchronous image decodes

[Simon Fraser (smfr)]

Created attachment 310974 [details]
Patch

[Simon Fraser (smfr)]

rdar://problem/32276146

[Build Bot]

Attachment 310974 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:513:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:639:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 310983 [details]
Patch

[Build Bot]

Attachment 310983 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:513:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:639:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/mac/WebLayer.mm:53:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/mac/WebLayer.mm:74:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
ERROR: Source/WebCore/platform/ios/LegacyTileLayer.mm:79:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
Total errors found: 5 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 310983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310983&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1566
> -void GraphicsLayerCA::platformCALayerPaintContents(PlatformCALayer*, GraphicsContext& context, const FloatRect& clip)
> +void GraphicsLayerCA::platformCALayerPaintContents(PlatformCALayer*, GraphicsContext& context, const FloatRect& clip, GraphicsLayerPaintFlags flags)

Hmm, why is this not just a bit on GraphicsContext?

> Source/WebCore/platform/graphics/mac/WebLayer.mm:55
> +@interface WebSimpleLayer () {
> +    BOOL _isRenderingInContext;
> +}

Don't think you can do this in 32 bit (you'll have to put it in the real interface).

[Simon Fraser (smfr)]

(In reply to Tim Horton from comment #6)
> Comment on attachment 310983 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310983&action=review
> 
> > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1566
> > -void GraphicsLayerCA::platformCALayerPaintContents(PlatformCALayer*, GraphicsContext& context, const FloatRect& clip)
> > +void GraphicsLayerCA::platformCALayerPaintContents(PlatformCALayer*, GraphicsContext& context, const FloatRect& clip, GraphicsLayerPaintFlags flags)
> 
> Hmm, why is this not just a bit on GraphicsContext?

Because with filters etc you can use several different GraphicsContexts, and you'd have to propagate the bit between them. Also I think this concept is slightly higher-level than GraphicsContext.

[Simon Fraser (smfr)]

Created attachment 311012 [details]
Patch

[Build Bot]

Attachment 311012 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:513:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:639:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/mac/WebLayer.mm:68:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
ERROR: Source/WebCore/platform/ios/LegacyTileLayer.mm:75:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
Total errors found: 4 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 311031 [details]
Patch

[Build Bot]

Attachment 311031 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:513:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:639:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/mac/WebLayer.mm:68:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
ERROR: Source/WebCore/platform/ios/LegacyTileLayer.mm:75:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
Total errors found: 4 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 311032 [details]
Patch

[Build Bot]

Attachment 311032 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:513:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:639:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/mac/WebLayer.mm:68:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
ERROR: Source/WebCore/platform/ios/LegacyTileLayer.mm:75:  Should not have spaces around = in property synthesis.  [whitespace/property] [4]
Total errors found: 4 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 311032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311032&action=review

> Source/WebCore/platform/graphics/mac/WebLayer.h:33
> +    BOOL m_isRenderingInContext;

Shouldn't have an m prefix.

> Source/WebCore/platform/graphics/mac/WebLayer.h:35
> +@property (nonatomic) BOOL _isRenderingInContext;

Why is this readwrite? Why does this have a leading underscore? This is an internal class. Should check with the SPI guidelines but I don't think the _ is required.

> Source/WebCore/platform/ios/wak/WAKWindow.h:136
> +- (void)setIsInSnapshottingPaint:(BOOL)isInSnapshottingPaint;
> +- (BOOL)isInSnapshottingPaint;

Why is this not a property :P

> Source/WebKit/mac/WebView/WebViewPrivate.h:-771
> -- (void)_setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:(BOOL)flag;
> -- (BOOL)_includesFlattenedCompositingLayersWhenDrawingToBitmap;

Are you sure it's OK to remove these?

[Simon Fraser (smfr)]

https://trac.webkit.org/r217296