Summary: | WPT resync should update moved and deleted tests in TestExpectations | ||
---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | cdumez, cturner, fred.wang, gsnedders, lforschler, ntim, rniwa, ryanhaddad, webkit-bug-importer, youennf |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=189241 https://bugs.webkit.org/show_bug.cgi?id=186359 |
Description
Alexey Proskuryakov
2017-05-22 13:57:02 PDT
Thanks for filing this issue, I'll check that for next resync manually. Maybe the script could help although the current TestExpectations format is not very adequate for scripts. The script could prompt to fix these manually if the lint output changes. (In reply to Alexey Proskuryakov from comment #2) > The script could prompt to fix these manually if the lint output changes. check-webkit-style usually prompts me when I leave orphaned paths, but maybe it ignores the files that haven't been edited. Renames are a challenge, because it's rather hard to determine what is _actually_ a rename. For example we have nearly 4000 files whose content is: <!-- This file is required for WebKit test infrastructure to run the templated test --> If we end up deleting one such file and adding a new one, that almost certainly isn't actually a rename. We can certainly do better than "nothing", but we will likely have to live with false-positives (because two tests can differ in terms of what support files get loaded). What we can definitely do correctly is remove lines where the test is deleted. |