Bug 172416

Summary:

make-new-script-test should create tests that use js-test.js, not js-test-pre.js

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Alexey Proskuryakov

Reported 2017-05-20 10:31:45 PDT

It is easier to use js-test in most cases. As I'm updating tests that misuse js-test-pre, I'm finding lots of convoluted and/or incorrect test code.

Attachments
proposed patch (1.59 KB, patch) 2017-05-20 10:33 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2017-05-20 10:33:26 PDT

Daniel Bates

Comment 2 2017-05-20 10:47:22 PDT

Comment on attachment 310774 [details] proposed patch OK.

WebKit Commit Bot

Comment 3 2017-05-20 11:15:10 PDT

Comment on attachment 310774 [details] proposed patch Clearing flags on attachment: 310774 Committed r217186: <http://trac.webkit.org/changeset/217186>

WebKit Commit Bot

Comment 4 2017-05-20 11:15:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.