Bug 172381

Summary: Web Inspector: Use initialLayout for DetailsSidebarPanel classes
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172393
https://bugs.webkit.org/show_bug.cgi?id=173185
Bug Depends on:    
Bug Blocks: 172303    
Attachments:
Description Flags
Patch
none
[Image] Timeline Before
none
[Image] Timeline After
none
Patch
timothy: review+
Patch none

Devin Rousso
Reported 2017-05-19 13:23:24 PDT
In addition, all of these classes are constructed during load on the WebInspector object. Each DetailsSidebarPanel should only be created once a tab that requires it is shown.
Attachments
Patch (66.46 KB, patch)
2017-05-19 13:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] Timeline Before (484.82 KB, image/png)
2017-05-19 13:40 PDT, Devin Rousso 		no flags
Details
[Image] Timeline After (451.93 KB, image/png)
2017-05-19 13:40 PDT, Devin Rousso 		no flags
Details
Patch (26.52 KB, patch)
2017-05-19 15:43 PDT, Devin Rousso 		timothy: review+
DetailsFormatted DiffDiff
Patch (27.02 KB, patch)
2017-06-02 19:59 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-05-19 13:40:33 PDT
Created attachment 310692 [details] Patch
Devin Rousso
Comment 2 2017-05-19 13:40:47 PDT
Created attachment 310693 [details] [Image] Timeline Before
Devin Rousso
Comment 3 2017-05-19 13:40:59 PDT
Created attachment 310694 [details] [Image] Timeline After
Matt Baker
Comment 4 2017-05-19 13:45:08 PDT
Comment on attachment 310692 [details] Patch This is going to be a pretty big change. I think we should remove global instantiation of panels as a stand alone patch. It is unrelated to the initialLayout/layout issue.
Devin Rousso
Comment 5 2017-05-19 15:43:29 PDT
Created attachment 310715 [details] Patch
Timothy Hatcher
Comment 6 2017-06-02 10:14:58 PDT
Comment on attachment 310715 [details] Patch Looks good. Please test this well.
Devin Rousso
Comment 7 2017-06-02 19:59:11 PDT
Created attachment 311900 [details] Patch
WebKit Commit Bot
Comment 8 2017-06-02 20:37:57 PDT
Comment on attachment 311900 [details] Patch Clearing flags on attachment: 311900 Committed r217749: <http://trac.webkit.org/changeset/217749>
WebKit Commit Bot
Comment 9 2017-06-02 20:37:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.