Bug 172324

Summary: Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, jonlee
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2017-05-18 17:15:48 PDT
We should strive to make them the same
Attachments
Patch (17.28 KB, patch)
2017-05-18 17:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (24.70 KB, patch)
2017-05-19 08:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (24.72 KB, patch)
2017-05-19 10:12 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.64 KB, patch)
2017-05-19 14:25 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-05-18 17:16:20 PDT
Created attachment 310577 [details] Patch
youenn fablet
Comment 2 2017-05-19 08:22:04 PDT
Created attachment 310658 [details] Patch
youenn fablet
Comment 3 2017-05-19 10:12:55 PDT
Created attachment 310671 [details] Patch
Eric Carlson
Comment 4 2017-05-19 13:29:36 PDT
Comment on attachment 310671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310671&action=review > Source/WebCore/ChangeLog:9 > + Removing most of MockRealtimeMediaSourceCenter implementation. Nit: "Removing" => "Remove"
youenn fablet
Comment 5 2017-05-19 14:25:53 PDT
Created attachment 310699 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-05-19 14:41:54 PDT
Comment on attachment 310699 [details] Patch for landing Clearing flags on attachment: 310699 Committed r217151: <http://trac.webkit.org/changeset/217151>
WebKit Commit Bot
Comment 7 2017-05-19 14:41:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.