Bug 172311

Summary: [macOS Sierra] Layout Test http/tests/dom/document-attributes-null-handling.html is flaky.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, kling, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Matt Lewis
Reported 2017-05-18 14:12:15 PDT
The test http/tests/dom/document-attributes-null-handling.html is flaky on Both WK1 and WK2 on macOS Sierra. The test fails more frequently on Sierra Debug. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fdom%2Fdocument-attributes-null-handling.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r217052%20(1076)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1076 Diff: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/dom/document-attributes-null-handling-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/dom/document-attributes-null-handling-actual.txt @@ -8,7 +8,7 @@ document.cookie = 'key=value' PASS document.cookie is "key=value" document.cookie = null -PASS document.cookie is "key=value; null=" +FAIL document.cookie should be key=value; null=. Was null=; key=value. * title attribute PASS document.title is ""
Attachments
Patch (2.52 KB, patch)
2017-05-18 19:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Lewis
Comment 1 2017-05-18 14:14:14 PDT
I was able to reproduce the failure on Sierra debug and release with: run-webkit-tests http/tests/dom/document-attributes-null-handling.html -f --iterations=500 --no-retry-failure and run-webkit-tests http/tests/dom/document-attributes-null-handling.html -f --iterations=500 --no-retry-failure --debug The failures were flaky and had to be run several times before failures occurred.
Chris Dumez
Comment 2 2017-05-18 19:36:15 PDT
Was able to reproduce, thanks. I'll take a look.
Chris Dumez
Comment 3 2017-05-18 19:41:33 PDT
Created attachment 310595 [details] Patch
Andreas Kling
Comment 4 2017-05-18 19:53:07 PDT
Comment on attachment 310595 [details] Patch r=me
WebKit Commit Bot
Comment 5 2017-05-18 20:21:57 PDT
Comment on attachment 310595 [details] Patch Clearing flags on attachment: 310595 Committed r217091: <http://trac.webkit.org/changeset/217091>
WebKit Commit Bot
Comment 6 2017-05-18 20:21:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.