Bug 172310 – [WebIDL] Remove the need for the generator to know about native type mapping

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

[WebIDL] Remove the need for the generator to know about native type mapping

[Sam Weinig]

Created attachment 310572 [details]
Patch

[Alex Christensen]

Comment on attachment 310572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310572&action=review

> Source/WebCore/Modules/geolocation/GeoNotifier.cpp:124
>          RefPtr<PositionError> error = PositionError::create(PositionError::TIMEOUT, ASCIILiteral("Timeout expired"));

Auto. Does this make a ref?

> Source/WebCore/bindings/js/JSNodeFilterCustom.cpp:41
> +unsigned short JSNodeFilter::acceptNode(Node& node)

Why is unsigned short preferable?

[Sam Weinig]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 310572 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310572&action=review
> 
> > Source/WebCore/Modules/geolocation/GeoNotifier.cpp:124
> >          RefPtr<PositionError> error = PositionError::create(PositionError::TIMEOUT, ASCIILiteral("Timeout expired"));
> 
> Auto. Does this make a ref?

Yes. Will update.
> 
> > Source/WebCore/bindings/js/JSNodeFilterCustom.cpp:41
> > +unsigned short JSNodeFilter::acceptNode(Node& node)
> 
> Why is unsigned short preferable?

It's just more inline with what the IDL says. But it really doesn't matter. I can change it back if you would prefer.

[Darin Adler]

Comment on attachment 310572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310572&action=review

> Source/WebCore/Modules/geolocation/Geolocation.cpp:511
>          RefPtr<PositionError> error = PositionError::create(PositionError::PERMISSION_DENIED,  ASCIILiteral(permissionDeniedErrorMessage));

auto/Ref

> Source/WebCore/Modules/geolocation/Geolocation.cpp:525
> +    RefPtr<Geoposition> position = lastPosition();
> +    if (position)

Would be nice to define inside the if. Does this need to go into a RefPtr rather than a raw pointer?

> Source/WebCore/Modules/geolocation/Geolocation.cpp:690
> +    RefPtr<Geoposition> position = lastPosition();
> +    ASSERT(position);

Does this need to go into a RefPtr rather than a raw pointer?

> Source/WebCore/Modules/geolocation/Geolocation.cpp:701
>      RefPtr<PositionError> positionError = createPositionError(error);

auto/Ref

> Source/WebCore/Modules/webaudio/AudioBufferCallback.idl:27
> +// DecodeErrorCallback, which takes DOMException. Currently, we pass and AudioBuffer

"and" -> "an"

> Source/WebKit/mac/DOM/DOM.mm:861
> -    return core(self)->acceptNode(core(node));
> +    return core(self)->acceptNode(*core(node));

Would be more elegant to throw an exception if someone passes nil rather than crashing.

[Sam Weinig]

Committed r217134: <http://trac.webkit.org/changeset/217134>