Bug 17226

Summary:

Patch to correct Windows(Cairo) build of image-decoders

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch adding #include "config.h"	aroben: review+

Brent Fulgham

Reported 2008-02-08 13:48:31 PST

The GIF and PNG image decoders do not include the "config.h" file, which causes various syntax errors such as: "IFImageDecoder.cpp c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2544: expected ')' for operator '()' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2143: syntax error : missing ';' before 'string' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2433: '()' : 'inline' not permitted on data declarations c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2059: syntax error : ')' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2143: syntax error : missing ';' before '{' c:\fulgham\webkit\webkitbuild\include\javascriptcore\FastMalloc.h(70) : error C2447: '{' : missing function header (old-style formal list?)"

Attachments
Patch adding #include "config.h" (1.42 KB, patch) 2008-02-08 13:49 PST, Brent Fulgham	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2008-02-08 13:49:07 PST

Created attachment 19008 [details] Patch adding #include "config.h"

Adam Roben (:aroben)

Comment 2 2008-02-08 13:50:04 PST

Comment on attachment 19008 [details] Patch adding #include "config.h" r=me

Mark Rowe (bdash)

Comment 3 2008-02-08 22:48:19 PST

Landed in r30107.

Note You need to log in before you can comment on or make changes to this bug.