Bug 172252

Summary: Bindings: Require value for extended attributes EnabledAtRuntime and EnabledForWorld
Product: WebKit Reporter: Daniel Bates <dbates>
Component: BindingsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sam
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch sam: review+

Daniel Bates
Reported 2017-05-17 16:30:18 PDT
In bug #172233, comment 2, Sam Weinig said that generating code when EnabledAtRuntime does not have a value is an "anti-feature". We should require that EnabledAtRuntime has a value. Similarly we should require that EnabledForWorld has a value. There is a larger discussion about whether to keep EnabledAtRuntime. Regardless of the outcome of this discussion fixing this bug is meaningful.
Attachments
Patch (2.79 KB, patch)
2017-05-17 16:37 PDT, Daniel Bates 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-05-17 16:37:49 PDT
Created attachment 310460 [details] Patch
Daniel Bates
Comment 2 2017-05-17 17:01:39 PDT
In case it was not obvious and as can be seen from the EWS failures we were using the "anti-feature" of specifying EnabledAtRuntime without a value on interfaces so that we could write: [ EnabledAtRuntime, ] interface A { ... } instead of: [ EnabledAtRuntime=A, ] interface A { ... }
Daniel Bates
Comment 3 2017-05-18 14:35:39 PDT
Committed r217066: <http://trac.webkit.org/changeset/217066>
Note You need to log in before you can comment on or make changes to this bug.