Bug 172251

Summary: [Win] Remove usage of _snprintf
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit Misc.Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, buildbot, cdumez, cmarcelo, commit-queue, dbates, pvollan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fix style
none
Patch none

Don Olmstead
Reported 2017-05-17 16:23:39 PDT
MSVC has had support for snprintf since Visual Studio 2015 https://msdn.microsoft.com/en-us/library/2ts7cx93.aspx.
Attachments
Patch (4.61 KB, patch)
2017-05-17 16:31 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch fix style (4.70 KB, patch)
2017-05-17 17:00 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (4.66 KB, patch)
2017-05-17 17:08 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-17 16:31:04 PDT
Created attachment 310457 [details] Patch Removes all usages of _snprintf outside of third party libraries
Build Bot
Comment 2 2017-05-17 16:33:21 PDT
Attachment 310457 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/win/PageLoadTestClient.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2017-05-17 17:00:59 PDT
Created attachment 310462 [details] Patch fix style Fixing style
Build Bot
Comment 4 2017-05-17 17:03:36 PDT
Attachment 310462 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/win/PageLoadTestClient.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 5 2017-05-17 17:08:58 PDT
Created attachment 310463 [details] Patch
Per Arne Vollan
Comment 6 2017-05-17 23:43:36 PDT
Comment on attachment 310463 [details] Patch Looks good! R=me.
WebKit Commit Bot
Comment 7 2017-05-18 00:12:17 PDT
Comment on attachment 310463 [details] Patch Clearing flags on attachment: 310463 Committed r217038: <http://trac.webkit.org/changeset/217038>
WebKit Commit Bot
Comment 8 2017-05-18 00:12:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.