Bug 172248

Summary:

[Win] Support $vm.getpid()

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

JavaScriptCore

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Don Olmstead

Reported 2017-05-17 15:28:49 PDT

Add Windows implementation of vm.getpid()

Attachments
Patch (1.91 KB, patch) 2017-05-17 15:37 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2017-05-17 15:37:04 PDT

Created attachment 310452 [details] Patch The original bug https://bugs.webkit.org/show_bug.cgi?id=163493 did not go for a windows implementation because of restrictions in getpid and _getpid. From MSDN https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps it appears that both _getpid and getpid should just use GetCurrentProcessId so getProcessId from ProcessID.h can be used since it calls that. Found this while trying to compile out JSCOnly on Windows. It fails on this file because PLATFORM(WIN) is used instead of OS(WINDOWS).

Mark Lam

Comment 2 2017-05-17 15:40:54 PDT

Comment on attachment 310452 [details] Patch LGTM. Did you mean to r? this patch?

Mark Lam

Comment 3 2017-05-17 15:45:12 PDT

Don Olmstead

Comment 4 2017-05-17 15:45:46 PDT

(In reply to Mark Lam from comment #3) > Comment on attachment 310452 [details] > Patch > > r=me Thanks for the review!

WebKit Commit Bot

Comment 5 2017-05-17 16:13:32 PDT

WebKit Commit Bot

Comment 6 2017-05-17 16:13:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.