Bug 172246

Summary: [WK2] Notify client when a process exceeds background CPU limit while in the foreground
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172244    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Patch none

Chris Dumez
Reported 2017-05-17 15:04:16 PDT
Notify client when a process exceeds background CPU limit while in the foreground.
Attachments
WIP Patch (18.69 KB, patch)
2017-05-17 15:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.38 KB, patch)
2017-05-19 12:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-17 15:04:44 PDT
<rdar://problem/32235411>
Chris Dumez
Comment 2 2017-05-17 15:05:49 PDT
Created attachment 310450 [details] WIP Patch
Chris Dumez
Comment 3 2017-05-17 15:08:26 PDT
Comment on attachment 310450 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310450&action=review > Source/WebKit2/UIProcess/WebProcessProxy.cpp:1167 > + // FIXME: We should call a delegate to notify the client we exceeded the background CPU limit while in the foreground (i.e. we would have terminated the process if it weren't visible). I am holding off on this part since Andreas seems pretty far along on Bug 172244, and we'll likely use the same client callback (with a different parameter).
Chris Dumez
Comment 4 2017-05-19 12:55:05 PDT
Created attachment 310687 [details] Patch
Geoffrey Garen
Comment 5 2017-05-19 14:42:05 PDT
Comment on attachment 310687 [details] Patch r=me
WebKit Commit Bot
Comment 6 2017-05-19 15:11:19 PDT
Comment on attachment 310687 [details] Patch Clearing flags on attachment: 310687 Committed r217153: <http://trac.webkit.org/changeset/217153>
WebKit Commit Bot
Comment 7 2017-05-19 15:11:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.