Bug 172233

Summary: Bindings: Add tests for EnabledAtRuntime without value
Product: WebKit Reporter: Daniel Bates <dbates>
Component: BindingsAssignee: Daniel Bates <dbates>
Status: RESOLVED INVALID    
Severity: Normal CC: buildbot, cdumez, esprehn+autocc, kondapallykalyan, sam
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test none

Daniel Bates
Reported 2017-05-17 11:47:14 PDT
Currently we have tests when the extended attribute EnabledAtRuntime has one or more values. We do not have any tests when EnabledAtRuntime has no value. When EnabledAtRuntime has no value then we fallback to looking for a function of the form RuntimeEnabledFeatures::sharedFeatures().XEnabled() where X is the name of the attribute, function, or interface annotated with EnabledAtRuntime. We should add a test to ensure that we do not regress this behavior.
Attachments
Test (10.82 KB, patch)
2017-05-17 11:48 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-05-17 11:48:08 PDT
Created attachment 310418 [details] Test
Sam Weinig
Comment 2 2017-05-17 14:18:32 PDT
This seems like an anti-feature. These should be explicit. I'd rather remove this shortcut (and as I have been saying elsewhere, stop using RuntimeEnabledFeatures altogether).
Daniel Bates
Comment 3 2017-05-17 16:30:40 PDT
(In reply to Sam Weinig from comment #2) > This seems like an anti-feature. These should be explicit. I'd rather remove > this shortcut (and as I have been saying elsewhere, stop using > RuntimeEnabledFeatures altogether). Filed bug #172252 to remove this anti-feature.
Note You need to log in before you can comment on or make changes to this bug.