Bug 172226
| Summary: | [WK1] RenderElement::isVisibleInDocumentRect() always returns true when it's given FrameView::windowClipRect() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, cdumez, koivisto, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
The behavior is different on WK2 from WK1. We need a way to check whether the RenderElement is visible in the viewport or not. The accuracy of this check is needed to pause the animation and to destroy the decoded frames for the elements outside the viewport.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Antti worked on this a long time ago iirc. I seem to remember we did not need to do anything special to pause images in WK1 because it worked differently somehow (e.g. GIF animation is triggered by painting and we never paint outside the viewport on WK1 or something like that).
Simon Fraser (smfr)
This depends on FrameView::paintsEntireContents(), which is true if the WebHTMLView is layer-backed.